On Thu, Mar 16, 2017 at 11:46 AM, David Steele <da...@pgmasters.net> wrote: > $ patch -p1 < ../other/postgres-fdw-subquery-support-v15.patch > patching file contrib/postgres_fdw/deparse.c > Hunk #11 succeeded at 1371 (offset -3 lines). > Hunk #12 succeeded at 1419 (offset -3 lines). > Hunk #13 succeeded at 1486 (offset -3 lines). > Hunk #14 succeeded at 2186 (offset -3 lines). > Hunk #15 succeeded at 3082 (offset -3 lines). > patching file contrib/postgres_fdw/expected/postgres_fdw.out > patching file contrib/postgres_fdw/postgres_fdw.c > Hunk #1 succeeded at 669 (offset 1 line). > Hunk #2 succeeded at 1245 (offset -1 lines). > Hunk #3 succeeded at 2557 (offset -1 lines). > Hunk #4 succeeded at 4157 (offset 3 lines). > Hunk #5 succeeded at 4183 (offset 3 lines). > Hunk #6 succeeded at 4212 (offset 3 lines). > Hunk #7 succeeded at 4315 (offset 3 lines). > patching file contrib/postgres_fdw/postgres_fdw.h > patching file contrib/postgres_fdw/sql/postgres_fdw.sql > > Since these are just offsets I'll leave the patch as "Needs review" but > an updated patch would be appreciated.
I don't think that's really needed. Offsets don't hurt anything. Even fuzz is OK. As long as the hunks are applying, I think it's fine. Incidentally, I'm reading through this one now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
