Robert, * Robert Haas (robertmh...@gmail.com) wrote: > So was this 3340 line patch posted or discussed anyplace before it got > committed?
I've mentioned a few times that I'm working on improving pg_dump regression tests and code coverage, which is what these were. I'm a bit surprised that it's, apparently, a surprise to anyone or that strictly adding regression tests in the existing framework deserves very much discussion. What I think would be great would be some additional work on our code coverage, which is abysmal. This, at least, gets us up over 80% for src/bin/pg_dump, but there's still quite a bit of work to be done there, as noted in the commit message, and lots of opportunity for improvement throughout the rest of the code base, as https://coverage.postgresql.org shows. Thanks! Stephen
Description: Digital signature