On Wed, Mar 22, 2017 at 1:31 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > Okay, switched as ready for committer. One note for the committer > though: keeping the calls of pgstat_bestart() out of > BackgroundWorkerInitializeConnection() and > BackgroundWorkerInitializeConnectionByOid() keeps users the > possibility to not have backends connected to the database show up in > pg_stat_activity. This may matter for some users (cloud deployment for > example). I am as well in favor in keeping the work of those routines > minimal, without touching at pgstat.
I think that's just inviting bugs of omission, in both core and extension code. I think it'd be much better to do this in a centralized place. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
