On Thu, Mar 23, 2017 at 12:34 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote:
> On 3/23/17 05:34, Andreas Karlsson wrote: > > I am fine with this version of the patch. The issues I have with it, > > which I mentioned earlier in this thread, seem to be issues with ICU > > rather than with this patch. For example there seems to be no way for > > ICU to validate the syntax of the BCP 47 locales (or ICU's old format). > > But I think we will just have to accept the weirdness of how ICU handles > > locales. > > > > I think this patch is ready to be committed. > > > > Found a typo in the documentation: > > > > "The inspect the currently available locales" should be "To inspect the > > currently available locales". > > Committed. > This has broken the C locale, and the build farm. if (pg_database_encoding_max_length() > 1 || locale->provider == COLLPROVIDER_ICU) segfaults because locale is null. (locale_is_c is true) Cheers, Jeff
