On Tue, Mar 28, 2017 at 11:25 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > As noted in the other thread, we could either fix this in a > quick-and-dirty way by casting XLR_BLOCK_ID_DATA_SHORT and related > values to "char" explicitly, or we could run around and change the > target pointer variables to be "unsigned char *". The latter could > prove to be pretty invasive if we try to carry it out fully, while > if we don't, then we're arguably just moving the ugly casts someplace > else. > > Opinions?
signed char sucks. Let's hit it with a stick. :-) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers