Thanks for the review. On Thu, Mar 30, 2017 at 7:37 PM, Kyotaro HORIGUCHI wrote: > At Thu, 30 Mar 2017 18:24:16 +0900, Amit Langote wrote: >> On 2017/03/29 23:58, Robert Haas wrote: >> > On Wed, Mar 29, 2017 at 4:21 AM, Amit Langote >> > <langote_amit...@lab.ntt.co.jp> wrote: >> >> Looks correct, so incorporated in the attached updated patch. Thanks. >> > >> > This seems like a hacky way to limit the reloptions to just OIDs. >> > Shouldn't we instead have a new RELOPT_KIND_PARTITIONED or something >> > like that? >> >> OK, I tried that in the updated patch. > > The name RELOPT_KIND_PARTITIONED looks somewhat odd. RELKIND for > partitioned tables is RELKIND_PARTITIONED_TABLE, so is this > better to be _TABLE, even if a bit longer?
Hm, OK. Done. > parseRelOptions seems to return garbage pointer if no option of > the kind is available. Oops, fixed that too. Updated patch attached. Thanks, Amit
Description: Binary data
-- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers