On Tue, Apr 11, 2017 at 9:45 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Amit Langote <langote_amit...@lab.ntt.co.jp> writes: >> 2. DefineQueryRewrite() may try to scan a partitioned table in the case of >> converting a table to view, where we must make sure that the table being >> converted is empty. It's checked by scanning the heap, which we should >> not do for a partitioned table. Nor should we try to drop the storage >> once ready to make the table into a REKIND_VIEW relation (because all >> other checks passed okaying the conversion). > > It looks like this patch intends to allow converting a partitioned table > to a view. I would lobby for refusing the command, instead. There is > no good reason to allow it, and it might well be a user error.
Yeah, I agree. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers