On Thu, Mar 30, 2017 at 4:13 AM, Pavan Deolasee <pavan.deola...@gmail.com> wrote:
> > > On Thu, Mar 30, 2017 at 3:29 PM, Dilip Kumar <dilipbal...@gmail.com> > wrote: > >> On Wed, Mar 29, 2017 at 11:51 AM, Pavan Deolasee >> <pavan.deola...@gmail.com> wrote: >> > Thanks. I think your patch of tracking interesting attributes seems ok >> too >> > after the performance issue was addressed. Even though we can still >> improve >> > that further, at least Mithun confirmed that there is no significant >> > regression anymore and in fact for one artificial case, patch does >> better >> > than even master. >> >> I was trying to compile these patches on latest >> head(f90d23d0c51895e0d7db7910538e85d3d38691f0) for some testing but I >> was not able to compile it. >> >> make[3]: *** [postgres.bki] Error 1 >> > > Looks like OID conflict to me.. Please try rebased set. > broken again on oid conflicts for 3373 to 3375 from the monitoring permissions commi 25fff40798fc4. After bumping those, I get these compiler warnings: heapam.c: In function 'heap_delete': heapam.c:3298: warning: 'root_offnum' may be used uninitialized in this function heapam.c: In function 'heap_update': heapam.c:4311: warning: 'root_offnum' may be used uninitialized in this function heapam.c:4311: note: 'root_offnum' was declared here heapam.c:3784: warning: 'root_offnum' may be used uninitialized in this function heapam.c: In function 'heap_lock_tuple': heapam.c:5087: warning: 'root_offnum' may be used uninitialized in this function And I get a regression test failure, attached. Cheers, Jeff
regression.diffs
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
