Hi, On 2017-04-01 01:22:14 +0000, Robert Haas wrote: > Avoid GatherMerge crash when there are no workers.
I think the gather merge code needs a bit more test coverage (sorry to make this a larger theme today). As shown by https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html we don't actually merge anything (heap_compare_slots is not exercised). I btw also wonder if it's good that we have a nearly identical copy of heap_compare_slots and a bunch of the calling code in both nodeMergeAppend.c and nodeGatherMerge.c. On the other hand, it's not heavily envolving code. - Andres -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers