On 3/25/17 12:24, Stephen Frost wrote: >> Add COMMENT and SECURITY LABEL support for publications and subscriptions > > Isn't this missing psql tab completion, and pg_dump support? And > regression tests for the latter?
I have added the tab completion support. Attached is a patch that adds the pg_dump support, but I'm struggling to make the tests work. Could you take a look? Problem one I'm seeing is that the tests assert that there are no comments in the post-data section, which is no longer the case here. Problem two is that subscriptions are not dumped by default, so those new tests fail, but I don't understand why the existing tests about subscriptions work so far. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
0001-pg_dump-Dump-comments-and-security-labels-for-public.patch
Description: invalid/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
