Andreas Karlsson <andr...@proxel.se> writes: > Here is my proof of concept patch. It does basically the same thing as > Andres's patch except that it handles quoted values a bit better and > does not try to support anything other than the regproc type.
> The patch speeds up initdb without fsync from 0.80 seconds to 0.55 > seconds, which is a nice speedup, while adding a negligible amount of > extra work on compilation. I've pushed this with some mostly-cosmetic adjustments: * created a single subroutine that understands how to split DATA lines, rather than having several copies of the regex * rearranged the code so that the data structure returned by Catalog::Catalogs() isn't scribbled on (which was already happening before your patch, but it seemed pretty ugly to me) * stripped out the bootstrap-time name lookup code from all of reg* not just regproc. There's certainly lots more that could be done in the genbki code, but I think all we can justify at this stage of the development cycle is to get the low-hanging fruit for testing speedups. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers