On Tue, Apr 25, 2017 at 7:42 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 4/24/17 22:50, Peter Eisentraut wrote: >> On 4/14/17 00:24, Ashutosh Bapat wrote: >>> This looks better. Here are patches for master and 9.6. >>> Since join pushdown was supported in 9.6 the patch should be >>> backported to 9.6 as well. Attached is the patch (_96) for 9.6, >>> created by rebasing on 9.6 branch and removing conflict. _v6 is >>> applicable on master. >> >> Committed to PG10. I'll work on backpatching next. > > For backpatching to 9.6, I came up with the attached reduced version. > Since we don't have add_foreign_grouping_paths() in 9.6, we can omit the > refactoring and keep the changes much simpler. Does that make sense?
Looks good to me. There's minor complaint. In case we change the option related functions in master because of a bug, backpatching those changes to 9.6 may not be straightforward. There's very less chance that we will require to change those functions, so may be we can take that theoretical risk. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers