On Wed, Apr 26, 2017 at 6:22 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 04/25/2017 06:26 PM, Heikki Linnakangas wrote: >> Thoughts? Unless someone has better ideas or objections, I'll go >> implement that. > This is what I came up with in the end. Some highlights and differences vs > the plan I posted earlier: > > * If algorithm is not given explicitly, PQencryptPasswordConn() queries > "SHOW password_encryption", and uses that. That is documented, and it is > also documented that it will *not* issue queries, and hence will not block, > if the algorithm is given explicitly. That's an important property for some > applications. If you want the default behavior without blocking, query "SHOW > password_encryption" yourself, and pass the result as the 'algorithm'.
TBH, I'd just require the user to specify the algorithm explicitly. Having it run SHOW on the server seems wonky. It introduces a bunch of failure modes for ... no real benefit, I think. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers