> >>> I would refrain from doing that, having some parameters listed in the > >>> tests makes the intention behind those perl routines clear. > > > > Hmm, you've got a point. But when we changed the default values > > related to replication we dropped some explicitly settings from the > > regression test code. > > Looking at the patch. This is fine: > - # Change a setting and restart > - $node->append_conf('postgresql.conf', 'hot_standby = on'); > - $node->restart(); > > But not that: > print $conf "wal_log_hints = on\n"; > - print $conf "hot_standby = on\n"; > print $conf "max_connections = 10\n"; > > This is a minor point though.
Thanks, I attached the update patch. --- Thanks and best regards, Dang Minh Huong NEC Solution Innovators, Ltd. http://www.nec-solutioninnovators.co.jp/en/
-- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers