Amit, * Amit Langote (amitlangot...@gmail.com) wrote: > On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfr...@snowman.net> wrote: > > * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > >> Attached updated patches. > > > > Please find an updated version which corrects the issue with > > binary-upgrade of partitioned tables having partitions in other schemas, > > along with a few other minor improvements. > > > > If you could take a look at it, I'd appreciate it. We already had a > > test case in the pg_dump TAP tests for partitions existing in a schema > > different from the partitioned table, but we weren't checking the > > binary-upgrade case, so I've added a check to do that now. I'm sure > > additional tests would be good to add and will take a look at doing that > > tomorrow, but this hopefully closes at least the latest issue. > > > > Assuming this looks good to you, I'll push it tomorrow, possibly with > > other minor adjustments and perhaps a few more tests. > > Your latest patch looks good to me.
Ok, great, thanks for taking a look at it. Too late for me to push it tonight, so I'll do so tomorrow. Thanks again! Stephen
Description: Digital signature