Hello Pavel,

Patch applies cleanly and compiles.

Idem for v2. "make check" ok. Tests look good.

I would suggest some rewording, maybe:

"Show the description of the result of the current query buffer without
actually executing it, by considering it a prepared statement."


Ok. If some native English speaker can clarify the sentence further, or imprive it anyway, thanks in advance!

  SELECT $1 AS unknown_type \gdesc

It is not unknown type - the default placeholder type is text

Indeed. I really meant something like:

  calvin=# SELECT $1 + $2 \gdesc
  ERROR:  operator is not unique: unknown + unknown

More comments:

I propose that the help message could be "describe result of query without executing it".

I found an issue. \gdesk fails when the command does not return a result:

 calvin=# TRUNCATE pgbench_history \gdesc
 ERROR:  syntax error at or near ")"
 LINE 2:  (VALUES ) s (name, tp, tpm)

I guess the issue is that PQdescribePrepared returns an empty description, which is fine, but then the second query should be skipped, and some message should be output instead, like "no result" or whatever...

This need fixing, and a corresponding test should be added.

Also I would suggest to add a \g after the first test, which would execute the current buffer after its description, to show that the current buffer does indeed hold the query:

 calvin=# SELECT 1 as one, ... \gdesc \g
 -- one | int
 -- ...
 -- 1 | ...


Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to