Hi, While browsing through the partitioning code, I noticed that a recent commit f8bffe9e6d700fd34759a92e47930ce9ba7dcbd5, which fixes multi-column range partitioning constraints, introduced a function make_partition_op_expr, that takes keynum as a input parameter to identify the index of the partition key. In case of range partition we can have multiple partition keys but for list partition we have only one. Considering that, I think following code does not cause any side-effect logically(and may be a oversight while moving the code from function get_qual_for_list to this function):
saopexpr->inputcollid = key->partcollation[0]; saopexpr->args = list_make2(arg1, arg2); But as we have keynum now, should we be using it to index key->partcollation, instead of a hard coded '0'. I tried to look around in list partitioning and hard coded '0' is used at all the places, but that code is either list specific or does not have availability of partitioned key index. Attached patch does this small change in make_partition_op_expr. Another way is to, have an Assert in case of PARTITION_STRATEGY_LIST: Assert(keynum != 0); PFA. Regards, Jeevan Ladhe
fix_indexing_make_partition_op_expr_v1.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
