On 5/23/17 02:33, Kuntal Ghosh wrote: >> The command succeed even if slot_name is invalid. That's because slot_name >> isn't validated. ReplicationSlotValidateName() should be called in >> parse_subscription_options() to avoid a pilot error. IMHO we should prevent >> a future error (use of invalid slot name). >> > +1. Since, slot_name can be provided even when create_slot is set > false, it should be validated as well while creating the subscription.
This came up in a previous thread. It is up to the publishing end what slot names it accepts. So running the validation locally is incorrect. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers