On 2017/06/01 10:26, Peter Eisentraut wrote: > On 5/31/17 02:17, Kuntal Ghosh wrote: >> On Wed, May 31, 2017 at 12:58 AM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> >>> I'd say we can fix this issue by just changing the query. Attached >>> patch changes the query so that it can handle publication name >>> correctly, the query gets complex, though. >>> >> In is_publishable_class function, there are four conditions to decide >> whether this is a publishable class or not. >> >> 1. relkind == RELKIND_RELATION >> 2. IsCatalogClass() >> 3. relpersistence == 'p' >> 4. relid >= FirstNormalObjectId /* Skip tables created during initdb */ >> >> I think the modified query should have a check for the fourth condition as >> well. > > The query should be fixed like in the attached patch. > pg_get_publication_tables() ends up calling is_publishable_class() > internally.
Looks good to me. Thanks, Amit -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers