On Fri, Jun 2, 2017 at 7:20 PM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 02/06/17 15:37, Amit Kapila wrote: >> >> No, it is to avoid calling free of memory which is not reserved on >> retry. See the comment: >> + * On the first try, release memory region reservation that was made by >> + * the postmaster. >> >> Are you referring to the same function in sysv_shm.c, if so probably I >> can say refer the same API in win32_shmem.c or maybe add a similar >> comment there as well? >> > > Yeah something like that would help, but my main confusion comes from > the fact that there is counter (and even named as such) but only > relevant difference is 0 and not 0. I'd like mention of that mainly > since I was confused by that on the first read. >
Okay, I have added the comment to explain the same. I have also modified the patch to adjust the looping as per your suggestion. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
win_shm_retry_reattach_v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
