On Thu, Jun 8, 2017 at 3:13 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Jun 6, 2017 at 8:19 PM, Peter Geoghegan <p...@bowt.ie> wrote: >> On Tue, Jun 6, 2017 at 5:01 PM, Peter Geoghegan <p...@bowt.ie> wrote: >>> Also, ISTM that the code within ENRMetadataGetTupDesc() probably >>> requires more explanation, resource management wise. > > Why so? I'm not saying you're wrong, but I don't see what's confusing > about the status quo. I may be missing something important.
Perhaps nothing. I just thought it looked a bit odd to rely on the target relation's TupleDesc like that. It's not quite the same as the foreign table tuplestore stuff, because that has its own relkind, and has a relation RTE in the parser. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers