This comment in an error handling in ExecPartitionCheck():

    if (!ExecCheck(resultRelInfo->ri_PartitionCheckExpr, econtext))
        char       *val_desc;
        Relation    orig_rel = rel;

        /* See the comment above. */
        if (resultRelInfo->ri_PartitionRoot)

should be updated because we don't have any comment on that above in the code. Since we have a comment on that in ExecConstraints() defined just below that function, I think the comment should be something like this: "See the comment in ExecConstraints().". Attached is a patch for that.

Best regards,
Etsuro Fujita
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index 0f08283..dcf685a 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -1864,7 +1864,7 @@ ExecPartitionCheck(ResultRelInfo *resultRelInfo, 
TupleTableSlot *slot,
                char       *val_desc;
                Relation        orig_rel = rel;
-               /* See the comment above. */
+               /* See the comment in ExecConstraints(). */
                if (resultRelInfo->ri_PartitionRoot)
                        HeapTuple       tuple = ExecFetchSlotTuple(slot);
Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to