On Mon, Jul 10, 2017 at 3:27 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hi, > > At Mon, 10 Jul 2017 14:58:13 +0530, Amit Kapila <amit.kapil...@gmail.com> > wrote in <CAA4eK1JYyO5Hcxx4rP0jb=jmmc4qvy1yvg9uvkwnr5qrojs...@mail.gmail.com> > >> I am also not 100% comfortable with adding flush at two new places, >> but that makes the code for fix simpler and fundamentally there is no >> problem in doing so. > > I agree that the patch would be simpler. Ok, I am satisfied with > an additional comment for _hash_init and hash_xlog_init_meta_page > that describes the reason that _hash_init doesn't/can't use > log_newpage and thus requires explicit flushes. Something like > the description in [1] would be enough. >
I have modified the comment in hash_xlog_init_meta_page and a corresponding function for bitmap page. However, I think adding anything about not using log_newpage in _hash_init doesn't sound good to me. I think you have suggested it so that we don't forget the reason for not using log_newpage, but I think that is overkill. Let me know if you have any other concerns? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
fix_unlogged_hash_index_issue_v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
