On 2017-07-17 23:04:43 +0200, Julien Rouhaud wrote: > On 17/07/2017 16:57, Andres Freund wrote: > > The latter obviously isn't ready, but might make clearer what I'm > > thinking about. > > It did for me, and FWIW I like this approach.
Cool. > > If we were to go this route we'd have to probably move > > the callback assignment into the ExecInit* routines, and possibly > > replace the switch in ExecInitNode() with another callback, assigned in > > make_*, and implement callbacks for ExecShutdown, MultiExecProcNode etc. > > > > This results in a good speedup in tpc-h btw: > > master total min: 46434.897 cb min: 44778.228 [diff -3.70] > > Is it v11 material or is there any chance to make it in v10? I think it'd make sense to apply the first to v10 (and earlier), and the second to v11. I think this isn't a terribly risky patch, but it's still a relatively large change for this point in the development cycle. I'm willing to reconsider, but that's my default. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
