Hi all, In snapbuild.c file, there is a comment as follows.
* NB: Because of that xmax can be lower than xmin, because we only * increase xmax when a catalog modifying transaction commits. While odd * looking, it's correct and actually more efficient this way since we hit * fast paths in tqual.c. */ Maybe we can get rid of the second "because" in the first sentence? Attached patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 153d171..55026ed 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -1116,10 +1116,10 @@ SnapBuildProcessRunningXacts(SnapBuild *builder, XLogRecPtr lsn, xl_running_xact * so, because we only need to do it for catalog transactions since we * only ever look at those. * - * NB: Because of that xmax can be lower than xmin, because we only - * increase xmax when a catalog modifying transaction commits. While odd - * looking, it's correct and actually more efficient this way since we hit - * fast paths in tqual.c. + * NB: Because of that xmax can be lower than xmin, we only increase xmax + * when a catalog modifying transaction commits. While odd looking, it's + * correct and actually more efficient this way since we hit fast paths + * in tqual.c. */ builder->xmin = running->oldestRunningXid;
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
