On 2017-09-05 11:36:47 +0900, Michael Paquier wrote: > On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander <mag...@hagander.net> wrote: > > PFA an updated and rebased patch. > > > > Rebased. Now named pg_advance_replication_slot. ERROR on logical slots. > > Forward only. > > > > I think that, in the end, covered all the comments? > > + if (backwards) > + ereport(WARNING, > + (errmsg("Not moving replication slot backwards!"))); > Shouldn't this be an ERROR, mentioning the current position of the slot? > > + ereport(ERROR, > + (errmsg("Only physical replication slots can be > advanced."))); > ERRCODE_FEATURE_NOT_SUPPORTED, no?
Seither of these seem to follow the message guidelines. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers