On Thu, Sep 07, 2017 at 10:49:54PM +0200, Dmitry Dolgov wrote: > On 29 August 2017 at 22:42, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > To make a review little bit easier I've divided the patch into a few > smaller parts. > > Apparently I forgot about subscripting for the name data type, so here is a > small update of the patch.
Thank you for rebasing the patch! PostgreSQL and documentation with the patch compiles without any errors. All regression tests passed. But honestly I still cannot say that I agree with *_extract() and *_assign() functions creation way. For example, there is no entry in pg_depend for them (related with pg_type entry). Because there is no such entry, there is the following bug: 1 - make and install src/tutorial 2 - run src/tutorial/subscripting.sql 3 - run: =# drop function custom_subscripting_extract(internal); 4 - and we get the error: =# select data[0] from test_subscripting; ERROR: function 0x55deb7911bfd returned NULL But of course it is only my opinion and I could be wrong. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
