On 14 September 2017 at 06:43, Amit Langote > langote_amit...@lab.ntt.co.jp> wrote: > Attached updated patch.
@@ -1222,151 +1209,130 @@ PartitionDispatch * RelationGetPartitionDispatchInfo(Relation rel, int *num_parted, List **leaf_part_oids) { + List *pdlist; PartitionDispatchData **pd; + get_partition_dispatch_recurse(rel, NULL, &pdlist, leaf_part_oids); Above, pdlist is passed uninitialized. And then inside get_partition_dispatch_recurse(), it is used here : *pds = lappend(*pds, pd); -------- pg_indent says more alignments needed. For e.g. gettext_noop() call below needs to be aligned: pd->tupmap = convert_tuples_by_name(RelationGetDescr(parent), tupdesc, gettext_noop("could not convert row type")); -------- Other than that, the patch looks good to me. I verified that the leaf oids are ordered exaclty in the order of the UPDATE subplans output. -- Thanks, -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers