On 9/14/17 11:01, David Steele wrote:
> On 9/8/17 1:32 PM, Peter Eisentraut wrote:
>> Yes, some of the error messages had changed.  Fixed patches attached.
> Patches apply and all tests pass.  A few comments:
> * [PATCH v2 1/7] adminpack: Add test suite
> There are no regular tests for pg_logdir_ls().

Added a comment about that.

> * [PATCH v2 4/7] chkpass: Add test suite
> Well, this is kind of scary:
> +WARNING:  type input function chkpass_in should not be volatile
> I guess the only side effect is that this column cannot be indexed?  The
> docs say that, so OK, but is there anything else a user should be
> worried about?

Well, we're just testing, not judging. ;-)

> The rest looks good.  I'll mark this "Ready for Committer" since I'm the
> only reviewer.  I don't think anything you might add based on my
> comments above requires a re-review.
> As for testing on more platforms, send it to the build farm?

OK, committed, let's see.

Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to