On Sun, Sep 17, 2017 at 8:49 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra >> <tomas.von...@2ndquadrant.com> wrote: >>> I've been running some regression tests under valgrind, and it seems >>> select_parallel triggers some uses of uninitialized values in dshash. If >>> I'm reading the reports right, it complains about hashtable->size_log2 >>> being not being initialized in ensure_valid_bucket_pointers. >> >> Thanks. Will investigate. > > Yeah, it's a bug, I simply failed to initialise it. > ensure_valid_bucket_pointers() immediately fixes the problem (unless > the uninitialised memory had an unlikely value), explaining why it > works anyway. I'm a bit tied up today but will test and post a patch > tomorrow.
Here is a patch to fix that. -- Thomas Munro http://www.enterprisedb.com
0001-Fix-uninitialized-variable-in-dshash.c.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
