Michael Paquier wrote: > On Thu, Sep 28, 2017 at 12:06 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: >> I think the passwordcheck module as a whole is a dead end, security- >> wise. Myself, I've never seen the point in it. It runs at the wrong >> time, and there's no way to fix that. > > Client commands may be run on a trusted network as well, let's not > forget that. But I definitely agree that this is bad practice in > general to not hash passwords beforehand. Another thing that > passwordcheck is good at is being an example of hook use. I would > think that many people refer to it when implementing their own module > for whatever they want.
Right. I originally only wanted the hook, but was lobbied into writing the contrib module as well, to a) have a nice checkbox item for ill-concieved security check lists b) have an example of how the hook could be used. I still think that there is nothing wrong with adding some GUCs to the module, as long as there is nothing in it that can compromise overall security. Yours, Laurenz Albe -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers