On Mon, Oct 23, 2017 at 1:44 AM, Andrew Dunstan <andrew.duns...@2ndquadrant.com> wrote: > > > On 10/22/2017 12:11 PM, Andrew Dunstan wrote: >> >> On 10/21/2017 07:33 PM, Michael Paquier wrote: >>> On Sun, Oct 22, 2017 at 1:43 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>>> I don't think collecting all the arguments is particularly special --- >>>> format() or concat() for instance could possibly use this. You might >>>> need an option to say what to do with unknown. >>> In this case, we could just use a boolean flag to decide if TEXTOID >>> should be enforced or not. >> A generic function is going to look a little more complicated than this, >> though. The functions as coded assume that the function has a single >> variadic argument. But for it to be useful generically it really needs >> to be able to work where there are both fixed and variadic arguments (a >> la printf style functions). >> >> I guess a simple way would be to make the caller tell the function where >> the variadic arguments start, or how many to skip, something like that.
Sorry for the late reply, I was taking a long flight. Yes, that's actually the conclusion I am reaching when looking at the code by adding an argument to mark when the variadic arguments start. The headers of funcapi.h and funcapi.c need also a cleanup. > here's a patch that works that way, based on Michael's code. Patch not attached :) I still have a patch half-cooked, that I can send if necessary, but you are on it, right? -- Michael -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers