Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > Sorry. Here it is.
This comment is neither correct nor intelligible: /* important for value, key cannot being NULL */ I'd say just drop it. The checks for "could not determine data type" errors seem rather duplicative, too. <compulsive-neatnik-ism> The extern declaration seems to have been dropped in a rather random place in the .h file. </compulsive-neatnik-ism> Looks good otherwise. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers