On Thu, Oct 19, 2017 at 9:05 AM, Amit Khandekar <amitdkhan...@gmail.com> wrote: >> + * ExecAppendEstimate >> + * >> + * estimates the space required to serialize Append node. >> >> Ugh, this is wrong, but I notice it follows various other >> equally-wrong comments for other parallel-aware node types. I guess >> I'll go fix that. We are not in serializing the Append node. > > I didn't clealy get this. Do you think it should be "space required to > copy the Append node into the shared memory" ?
No, because the Append node is *NOT* getting copied into shared memory. I have pushed a comment update to the existing functions; you can use the same comment for this patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers