On Sat, Nov 4, 2017 at 2:03 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> On Fri, Nov 3, 2017 at 1:10 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >>> On Fri, Nov 3, 2017 at 2:54 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>>> I've marked the CF entry closed. However, I'm not sure if we're quite >>>> done with this thread. Weren't we going to adjust nbtree and hash to >>>> be more aggressive about labeling their metapages as REGBUF_STANDARD? > >>> I have already posted the patches [1] for the same in this thread and >>> those are reviewed [2][3] as well. I have adjusted the comments as per >>> latest commit. Please find updated patches attached. > >> Confirmed. Setting those makes sense even if REGBUF_WILL_INIT is set, >> at least for page masking. > > Thanks, I'd forgotten those patches were already posted. Looks good, > so pushed. > > Looking around, I noted that contrib/bloom also had the disease of > not telling log_newpage it was writing a standard-format metapage, > so I fixed that too. >
Thanks, Michael and Tom for reviewing and committing the work. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers