Nicolai Tufar wrote: > 1. I renamed snprintf() to pg_snprintf(), vsnprintf() to > pg_vsnprintf() and introduced pg_printf() that calls pg_vsnprintf().
This is not necessary. You will notice that we already have configure tests of snprintf format specifiers (%lld etc.), so using the original function names is OK even in that case. > 4. I introduced a volatile static char[] variable in snprintf.c code > so I can grep executables for this string and be sure that it is > included. Remove that when finalizing the code. > 5. Before running regression test I always ran make install, > apparently because libpq is read from /usr/local/. That's because of the -rpath. > 2. Why would we not just take FreeBSD's vfprintf() and use it > instead? Try it. It's painful. > 4. What %m format string is used for? And where is it handled. Do I > need to implement it? It's only used in the error reporting functions in the server and is handled there. You don't need to worry about it. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---------------------------(end of broadcast)--------------------------- TIP 4: Don't 'kill -9' the postmaster
