Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> This time around, please do not remove API functions just because you > >> can't find a reference to them in the core code. I would like to see > >> a posted, discussed patch first. > > > OK, here is my match to mark items as static or not used: > > ftp://momjian.us/pub/postgresql/mypatches/static > > By and large, this just demonstrates the silliness of using an automated > tool for this purpose :-(. The hits in gist and gin might be valid --- > Teodor would need to comment on that --- but almost every one of the > others is a "no, don't do that". As an example, you've successfully > reverted this recent patch in toto: > > 2006-04-26 20:46 tgl > > * src/: backend/utils/adt/selfuncs.c, include/utils/selfuncs.h: If > we're going to expose VariableStatData for contrib modules to use, > then we should export a reasonable set of the supporting routines > too. > > The fundamental problem with find_static is that it hasn't got a clue > about likely future changes, nor about what we think external add-ons > might want ...
OK, I don't really have a clue either. Is any of it valid? -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend
