Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> We could make it cleaner by inventing a function to clear out the cached > >> statistics within a transaction, perhaps "pg_stat_reset_snaphot()" or > >> some such name. If anyone thinks that that would be of general > >> usefulness, I'll see about making it happen. > > > I came up with the idea of storing the stat hash in a particular memory > > context, and have a flag in pgstat.c that's reset when that context is > > reset. So each caller can define what's the appropriate lifetime. > > None of your use-cases require tracking multiple sets of stats within a > transaction, so I don't see why bother with that when we can just add a > "flush the stats" call.
Yeah, it's the same thing (and simpler), except that you move the responsability of resetting the memory context to pgstats instead of the calling code. In any case, if you were to provide a mechanism for stats flush, autovacuum would have an use case for it, so that's a +1. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
