Joe Conway <[EMAIL PROTECTED]> writes:
> Note that I also changed behavior in that when trigdata->tg_event 
> doesn't match anything known -- instead of pressing on with a value of 
> "UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made 
> no sense to me, but you may not want to change existing behavior in this 
> way (even though it seems to me that it is a "should not happen" kind of 
> error).

Seems reasonable to me.  As a matter of style, the "unrecognized" elogs
should print the offending tg_event value; otherwise the patch looks fine.

> If this patch is acceptable, I'll make similar changes to plpython.

Please do.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

Reply via email to