Joe Conway <[EMAIL PROTECTED]> writes: > This patch includes pltcl and plpython, with the mentioned style issue > fixed. Both PLs pass their scripted tests and my simple statement level > trigger test.
Applied, thanks. BTW, one other stylistic nit: I don't think comments like /* internal error */ elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event); are really necessary. In the brave new ereport world, any elog(ERROR) call is an internal error by definition --- if it isn't, you should be using ereport. So the use of elog is sufficient documentation. IMHO anyway. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 4: Don't 'kill -9' the postmaster