> > > Here's a patch implementing the "thread method" to > > workaround the bug > > > with socket calls in signal handlers. See details in mail to > > > pgsql-hackers-win32 a couple of minutes ago. > > > > Looks ok, but wouldn't it be better placed in pgstat.c? > > Actually, I don't think so. I considered it, and chose to put it in > postmaster.c for the following reason: > > The functon pgstat_beterm itself is *not* the problem. In theory, it can > be called from places that are not signal handlers (sure, it's not done > today I think, but internal-API-wise, it could). That goes against > putting the fix ther.
Sure, like I said, my 2c. Just looks a little out of place. Understand point on API, but think it is clear that this isn't a win32 replacement for pgstat_beterm, but a win32 replacement for pgstat_beterm *called from a signal handler* (perhaps a function name change would make it this clearer). In any case, not fussed. What I am wondering about now, is where else we need to change? AFAICS, there is (at least?) one signal handler that performs sockets ops, namely Async_NotifyHandler. Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see <a href="http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em ailpolicy.html</a> ---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings
