Andrew Francis wrote:
> Tom Lane wrote:
> > Bruce Momjian <[EMAIL PROTECTED]> writes:
> > 
> >>The only other option I can think of is to #undef those to defines,
> >>include io.h, then re-include port.h?  Is that better?
> > 
> > How about not #define'ing rename() etc in port.h in the first place?
> > 
> > We could put
> >     #ifdef WIN32
> >     #define rename(x) pgrename(x)
> >     #endif
> > into those very few .c files that need it.
> 
> How about avoiding #define altogether, and:
> 
>   - Always use pgrename/pgunlink instead of rename/unlink
> 
>   - Provide stubs for non-Win32 systems
> 
> #ifndef WIN32
> int pgrename(const char *from, const char *to) {
>    return rename(from,to);
> }
> #endif
> 

We could do it but we have avoided that for cases where Unix would just
be a pass-through.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

Reply via email to