Mark Kirkwood wrote:
+               tupledesc = CreateTemplateTupleDesc(NUM_BUFFERCACHE_PAGES_ELEM, 
false);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 1, "bufferid",
+                                                                       
INT4OID, -1, 0);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 2, "relfilenode",
+                                                                       OIDOID, 
-1, 0);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 3, "reltablespace",
+                                                                       OIDOID, 
-1, 0);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 4, "reldatabase",
+                                                                       OIDOID, 
-1, 0);
+               TupleDescInitEntry(tupledesc, (AttrNumber) 5, "relblockbumber",
+                                                                       
NUMERICOID, -1, 0);


I think this should be an int4, not numeric.

Otherwise, looks good to me. Barring any objections, I'll apply this with a few stylistic tweaks and the numeric -> int4 change tomorrow.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

Reply via email to