The attached patch creates installcheck targets for plperl and pltcl (plpython laready has one). This will help in getting buildfarm to test PLs.


Is it worth rearranging things for plpython so that it follows the same test layout as the other 2 (i.e. a test subdir with all the test files and a script called runtest that does the work)? Especially if we bring in other PLs as has been discussed, some standard might be useful. Maybe a README in src/pl ?

I'm not sure that the tests currently provide very good coverage (especially plperl) but getting them run automatically might provide some extra incentive on that.

cheers

andrew
Index: plperl/GNUmakefile
===================================================================
RCS file: /home/cvsmirror/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.18
diff -c -r1.18 GNUmakefile
*** plperl/GNUmakefile	19 Nov 2004 19:22:58 -0000	1.18
--- plperl/GNUmakefile	11 May 2005 14:02:27 -0000
***************
*** 53,58 ****
--- 53,62 ----
  	 echo "*****"
  endif
  
+ installcheck:
+ 	cd $(srcdir)/test && PATH=$(bindir):$$PATH $(SHELL) runtest
+ 
+ 
  installdirs:
  	$(mkinstalldirs) $(DESTDIR)$(pkglibdir)
  
Index: tcl/Makefile
===================================================================
RCS file: /home/cvsmirror/pgsql/src/pl/tcl/Makefile,v
retrieving revision 1.44
diff -c -r1.44 Makefile
*** tcl/Makefile	16 Dec 2004 20:41:01 -0000	1.44
--- tcl/Makefile	11 May 2005 14:25:53 -0000
***************
*** 57,62 ****
--- 57,66 ----
  endif
  	$(MAKE) -C modules $@
  
+ installcheck:
+ 	cd $(srcdir)/test && PATH=$(bindir):$$PATH $(SHELL) runtest
+ 
+ 
  installdirs:
  	$(mkinstalldirs) $(DESTDIR)$(pkglibdir)
  	$(MAKE) -C modules $@
---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to