Bruce Momjian <pgman@candle.pha.pa.us> writes: > OK, snprintf.c fixed. I added a 'stream' and outlen parameter to all > the calls, and cleaned up the switch() statement that was outputing > twice. When we were outputing just to a string, it didn't matter, but > now that we are also outputting to a stream, it does.
I found a whole bunch more problems than this :-(. I've committed a cleaned-up version that seems to work correctly in a simple standalone testbed, but it'd be a good idea to exercise it inside PG as well. Can you try regression tests and the factorial() problem on CVS tip? The problems are sufficiently bad that it might be a good idea to backport the fixes into 8.0 and before as well --- but I note that the ABI is different (pg_snprintf vs snprintf, etc) so this requires a bit of investigation rather than just committing the file as-is. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly