Neil Conway wrote:

Context diffs are preferred. Also, diffs should be against the root of
the source tree, and attached as MIME attachements if possible (it seems
the mailing list software munges the patch somewhat otherwise).

Minor nit: lowercase "Append". Similarly, consistent capitalization for
all the preceding comments in the block (adjacent to the variable
declarations) would be nice.

tbstr points into storage owned by tb_log, but the reference to tb_log
has already been released.

I'm on it.

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?


Reply via email to