Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Attached patch adds GUC 'update_process_title' to control ps display > > updates per SQL command. Default to 'on'. GUC name OK? > > This is an ugly patch. Why not *one* test of the GUC variable, inside > set_ps_display(), and no side-effects on callers? You would need to > force an initial update from init_ps_display, but that only requires a > small amount of code refactoring inside ps_status.c.
Consider all the helper processes that set their process title. The only thing I can think of is to add a boolean to set_ps_display() so say whether this is per-command set or not. Is that your idea? > The one place that might be worth having an external test on the GUC is > in lock.c, but then it should bypass the entire business of copying, > modifying, and restoring the title ... not just the two set_ps_display > calls. OK, that makes sense. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend
