Zdenek Kotala wrote:
> OK. I split patch to two parts. Part one is refactoring of
> set_config_options function. Part two implements feature "Allow
> commenting of variables in postgresql.conf to restore them to
> defaults".

I'm having trouble wrapping my head around a code "refactoring" which 
actually makes the code significantly *longer*.  The only interface 
change I could detect is the introduction of a function 
verify_config_option(), which should just be a small variation on 
set_config_option() as it currently exists.

I'm also about a relive a personal trauma if I see error messages like 

    errmsg("configuration file is invalid")

I just had to deal with an unnamed product where this was all you got!

Please, explain again what this refactoring is supposed to achieve.

The second part of your patch actually looks pretty reasonable and does 
not appear to require the refactoring.

Peter Eisentraut

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?


Reply via email to