On Tue, 2007-03-20 at 18:20 +0000, Heikki Linnakangas wrote:
> This patch makes CLUSTER MVCC-safe. Visibility information and update 
> chains are preserved like in VACUUM FULL.

Sounds good.

> CLUSTER is currently the only user of the facility, but I'm envisioning 
> we might have other users in the future. For example, a version of 
> VACUUM FULL that rewrites the whole table. 

I would be very much in favour of that, as discussed on -hackers.

There might be some requirement for the older VACUUM FULL behaviour, so
I'd like to suggest the syntax:


where VACUUM FULL foo REPLACE STORAGE would be the new default, using
your new functions, and PRESERVE STORAGE would implement the old method.

> One complication in the implementation was the fact that heap_insert 
> overwrites the visibility information, and it doesn't write the full 
> tuple header to WAL. I ended up implementing a special-purpose 
> raw_heap_insert function instead, which is optimized for bulk inserting 
> a lot of tuples, knowing that we have exclusive access to the heap. 
> raw_heap_insert keeps the current buffer locked over calls, until it 
> gets full, and inserts the whole page to WAL as a single record using 
> the existing XLOG_HEAP_NEWPAGE record type.

I submitted Fast CLUSTER patch earlier which avoided writing WAL in the
same way that has been done for COPY, CREATE INDEX and CTAS. Would you
like to update your patch to do this also, or would you like me to
re-write the patch to fit with yours?

  Simon Riggs             
  EnterpriseDB   http://www.enterprisedb.com

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply via email to