Pavan Deolasee wrote:


On 1/28/07, *Tom Lane* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:

    OTOH it might be
    cleaner to refactor things that way, if we were going to apply this.


Here is a revised patch which includes refactoring of
heap_get_latest_tid(), as per Tom's suggestion.


I'm looking on your patch. I have one comment:

If you have old tid and new tid you can easy compare if new tid points to different page? And if page is still same there is no reason to Unlock it and lock again. I think add inner loop something like:


Readbufer
Lock
do{

...

} while(ctid.block_id == tid.block_id)
ReleaseAndUnlock

can save some extra locking/unlocking cycle. What do you think?


                Zdenek

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to